Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit test error #6953

Merged
merged 1 commit into from Nov 2, 2020
Merged

Fix unit test error #6953

merged 1 commit into from Nov 2, 2020

Conversation

Hellcatlk
Copy link
Contributor

Signed-off-by: zouyu zouy.fnst@cn.fujitsu.com

I get the error when I run the unit test:

go/netutil/netutil_test.go:59:30: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
FAIL	vitess.io/vitess/go/netutil [build failed]
FAIL

go version: go1.15.2 linux/amd64

@Hellcatlk
Fix unit test error
0803885 
Signed-off-by: zouyu <zouy.fnst@cn.fujitsu.com>
deepthi
deepthi approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deepthi deepthi merged commit 1e0ecb8 into vitessio:master Nov 2, 2020
@askdba askdba added this to the v9.0 milestone Nov 11, 2020
@rafael rafael mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Hellcatlk @deepthi @askdba