Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing online ddl query hint from ALTER TABLE #7069

Merged
merged 11 commits into from
Nov 25, 2020
Merged

Removing online ddl query hint from ALTER TABLE #7069

merged 11 commits into from
Nov 25, 2020

Commits on Nov 23, 2020

  1. Removed online_hint_opt from ALTER TABLE and CREATE INDEX queries 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    d772772 View commit details
    Browse the repository at this point in the history

  2. Removed GetOnlineHint from ast, and removed all references to it 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    ac7658d View commit details
    Browse the repository at this point in the history

  3. removed parsing code that handles 'WITH ...' clause 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    54b8392 View commit details
    Browse the repository at this point in the history

  4. minor update to parser_test 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    8a602e8 View commit details
    Browse the repository at this point in the history

  5. fix unit test 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    c4f217e View commit details
    Browse the repository at this point in the history

  6. adapt endtoend tests 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    dff9fb3 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. refactor DDLStrategy type out of sqlparser 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    f70620e View commit details
    Browse the repository at this point in the history

  2. typo 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    219ccaa View commit details
    Browse the repository at this point in the history

  3. a bit of refactor, no logic change 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    539be16 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into remove-online-ddl… 

    …-query-hint

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    3f6ccbb View commit details
    Browse the repository at this point in the history

  5. removed irrelevant comments 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    c74228d View commit details
    Browse the repository at this point in the history