Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support statsd for vitess #7072

Merged
merged 6 commits into from Nov 28, 2020
Merged

Support statsd for vitess #7072

merged 6 commits into from Nov 28, 2020

Conversation

5antelope
Copy link
Member

@5antelope 5antelope commented Nov 24, 2020

This tries to address #7064 and add very basic initial supports for statsd (we might need to tweak it a bit more later)

This PR mainly does 2 things:

  1. Make statsd available as a plugin for VTTablet and VTGate
  2. Export stats.Timings as histogram for now until we have better solution to store and export metrics directly as statsd.timing

Signed-off-by: crowu <y.wu4515@gmail.com>
Signed-off-by: crowu <y.wu4515@gmail.com>
Signed-off-by: crowu <y.wu4515@gmail.com>
Signed-off-by: crowu <y.wu4515@gmail.com>
Signed-off-by: crowu <y.wu4515@gmail.com>
Signed-off-by: crowu <y.wu4515@gmail.com>
@5antelope
Copy link
Member Author

Not sure if this build failure is related to my change https://github.com/vitessio/vitess/pull/7072/checks?check_run_id=1449541891 @sougou do you happen to know why this might fail on top of your head? Thanks!

@deepthi
Copy link
Member

deepthi commented Nov 24, 2020

Not sure if this build failure is related to my change https://github.com/vitessio/vitess/pull/7072/checks?check_run_id=1449541891 @sougou do you happen to know why this might fail on top of your head? Thanks!

We have seen this test fail before (randomly). I don't think it is related to your changes.

@5antelope
Copy link
Member Author

Good to know, thanks for confirming!

@deepthi / @sougou would any of you happen to be available to take a look at this change and see if it makes sense to you? Thanks!

Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. It's good to see that the feature is disabled unless stats_address is specified.

@sougou sougou merged commit 5254e65 into vitessio:master Nov 28, 2020
@askdba askdba added this to the v9.0 milestone Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants