Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go mod tidy #7137

Merged
merged 2 commits into from
Dec 9, 2020
Merged

go mod tidy #7137

merged 2 commits into from
Dec 9, 2020

Conversation

systay
Copy link
Collaborator

@systay systay commented Dec 8, 2020

No description provided.

Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay requested a review from sougou as a code owner December 8, 2020 08:13
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. need to fix conflict ...

@derekperkins
Copy link
Member

We should add a CI check that fails the build if go mod tidy isn't clean. This is what we have in our config.

go mod tidy
output=$(git status -s) && if [ ${#output} -eq 0 ]; then exit 0; else echo "$output"; exit 1; fi

Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit 478d8cc into vitessio:master Dec 9, 2020
@deepthi
Copy link
Member

deepthi commented Dec 9, 2020

We should add a CI check that fails the build if go mod tidy isn't clean. This is what we have in our config.

go mod tidy
output=$(git status -s) && if [ ${#output} -eq 0 ]; then exit 0; else echo "$output"; exit 1; fi

Good point.
@askdba can you please create an issue for this?

@askdba
Copy link
Contributor

askdba commented Dec 10, 2020

We should add a CI check that fails the build if go mod tidy isn't clean. This is what we have in our config.

go mod tidy
output=$(git status -s) && if [ ${#output} -eq 0 ]; then exit 0; else echo "$output"; exit 1; fi

Good point.
@askdba can you please create an issue for this?

#7154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants