Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for all the rails queries using information_schema #7143

Merged
merged 3 commits into from Dec 9, 2020
Merged

Adds support for all the rails queries using information_schema #7143

merged 3 commits into from Dec 9, 2020

Conversation

GuptaManan100
Copy link
Member

Adds support for all the rails queries using information_schema

@GuptaManan100
Added rails tests
7e3ad70 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
added support for constraint_schema and schema_name columns
18417d6 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100 GuptaManan100 added Component: Query Serving P2 Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Dec 9, 2020
systay
systay approved these changes Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐

@GuptaManan100
allow two predicates if they refer to the same table or schema
7994d9a 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@systay systay merged commit 7e4b552 into vitessio:master Dec 9, 2020
@systay systay deleted the rails-queries branch December 9, 2020 13:20
@askdba askdba added this to the v9.0 milestone Dec 10, 2020
@rafael rafael mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GuptaManan100 @systay @askdba