Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Code to create a separate struct for ALTER VSCHEMA #7173

Merged
merged 4 commits into from Dec 17, 2020
Merged

Refactor Code to create a separate struct for ALTER VSCHEMA #7173

merged 4 commits into from Dec 17, 2020

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Dec 14, 2020 •
edited

Refactor Code to create a separate struct for ALTER VSCHEMA which will not implement the DDL statement interface

@GuptaManan100
refactored AlterVschema to be its own struct
ba2e7d0 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Merge remote-tracking branch 'upstream/master' into alter-vschema
f1fce73 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
refactored code
2d1b007 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Added planning tests for Alter Vschema
e1a35c6 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100 GuptaManan100 marked this pull request as ready for review December 15, 2020 05:54
harshit-gangal
harshit-gangal approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat :)

@harshit-gangal harshit-gangal merged commit 55bfc00 into vitessio:master Dec 17, 2020
@askdba askdba added this to the v9.0 milestone Dec 23, 2020
@rafael rafael mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@sougou sougou Awaiting requested review from sougou

@systay systay Awaiting requested review from systay

Assignees
No one assigned
Labels
Component: Query Serving Type: Internal Cleanup
Projects
No open projects
Complete Parsing DDL Support for mysq...
Done
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GuptaManan100 @harshit-gangal @askdba