New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FindAllShardsInKeyspace to vtctldserver #7201
Merged
rohit-nayak-ps
merged 5 commits into
vitessio:master
from
tinyspeck:am_find_all_shards_in_keyspace
Dec 23, 2020
Merged
Add FindAllShardsInKeyspace to vtctldserver #7201
rohit-nayak-ps
merged 5 commits into
vitessio:master
from
tinyspeck:am_find_all_shards_in_keyspace
Dec 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
…o be backwards-compat Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
requested review from
deepthi,
rohit-nayak-ps and
sougou
as code owners
December 17, 2020 21:06
Signed-off-by: Andrew Mason <amason@slack-corp.com>
6 tasks
rohit-nayak-ps
approved these changes
Dec 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Jan 10, 2021
…_keyspace Add FindAllShardsInKeyspace to vtctldserver
This was referenced Jan 10, 2021
setassociative
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Mar 11, 2021
…_keyspace Add FindAllShardsInKeyspace to vtctldserver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
NO
Status
READY
Description
This PR adds the
FindAllShardsInKeyspace
command to the VtctldServer API. It also reimplements the vtctl command to use the same underlying codepath, but transforms the output to maintain backwards compatibility.Local testing example
For a local example, I went through the local example up through 30x (reshard example). Then, both commands:
Related Issue(s)
List related PRs against other branches:
#7135
Todos
Deployment Notes
N/A
Impacted Areas in Vitess
List general components of the application that this PR will affect: