New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make docker_local: fix missing mysql_server package #7213
make docker_local: fix missing mysql_server package #7213
Conversation
We use docker/lite/install_dependencies.sh to install mysql57 server and client Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
--------------
mysql Ver 14.14 Distrib 5.7.31, for Linux (x86_64) using EditLine wrapper
Connection id: 1
Current database: commerce
Current user: vt_app@localhost
SSL: Not in use
Current pager: stdout
Using outfile: ''
Using delimiter: ;
Server version: 5.7.9-Vitess MySQL Community Server (GPL)
Protocol version: 10
Connection: 127.0.0.1 via TCP/IP
Server characterset: utf8
Db characterset: utf8
Client characterset: utf8
Conn. characterset: utf8
TCP port: 15306
--------------```
…ysql-server Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Waiting a few more days before merging since Holidays are slow for reviews. |
…ysql-server Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Thank you so much for fixing this! 🎉 |
Self reminder to merge this on Wednesday since everyone was out for so long. |
If you merge it tomorrow it'll make it to v9.0.RC1 |
OK fine 😂 |
Description
We use
docker/lite/install_dependencies.sh
to install mysql57 server and clientRelated Issue(s)
An internal discussion leading to the finding that
make docker_local
is broken:Checklist
Impacted Areas in Vitess
Components that this PR will affect:
cc @askdba