Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make docker_local: fix missing mysql_server package #7213

Merged

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Dec 22, 2020

Description

We use docker/lite/install_dependencies.sh to install mysql57 server and client

Related Issue(s)

An internal discussion leading to the finding that make docker_local is broken:

$ make docker_local
Building vitess/local
Sending build context to Docker daemon  245.5MB
Step 1/20 : ARG bootstrap_version=0
Step 2/20 : ARG image="vitess/bootstrap:${bootstrap_version}-common"
Step 3/20 : FROM "${image}"
0-common: Pulling from vitess/bootstrap
b5fccd3d6845: Pull complete 
c25b21fd76f9: Pull complete 
ae6bd386dfb5: Pull complete 
66273862a1f5: Pull complete 
8dd00d46b611: Pull complete 
3a2640662882: Pull complete 
c7af44a17df4: Pull complete 
20e3098c40d6: Pull complete 
e5b9ee5cef7e: Pull complete 
45a16634d019: Pull complete 
341a945a6f03: Pull complete 
c2ee08fcd4ea: Pull complete 
241f187361b4: Pull complete 
1584544faa4a: Pull complete 
Digest: sha256:6351632555d1452e42fe683bc138e1c2234b99bfb4991d758dd74358d0bed8bd
Status: Downloaded newer image for vitess/bootstrap:0-common
 ---> 719ddf079ea4
Step 4/20 : RUN apt-get update
 ---> Running in 5862f956adc6
Get:1 http://security.debian.org/debian-security buster/updates InRelease [65.4 kB]
Get:2 http://deb.debian.org/debian buster InRelease [121 kB]
Get:3 http://deb.debian.org/debian buster-updates InRelease [51.9 kB]
Get:4 http://security.debian.org/debian-security buster/updates/main amd64 Packages [256 kB]
Get:5 http://deb.debian.org/debian buster/main amd64 Packages [7907 kB]
Get:6 http://deb.debian.org/debian buster-updates/main amd64 Packages [7856 B]
Fetched 8410 kB in 4s (2395 kB/s)
Reading package lists...
Removing intermediate container 5862f956adc6
 ---> cea4dd0a127c
Step 5/20 : RUN apt-get install -y sudo curl vim jq mysql-server
 ---> Running in 17b19a8e0597
Reading package lists...
Building dependency tree...
Reading state information...
Package mysql-server is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
E: Package 'mysql-server' has no installation candidate
The command '/bin/sh -c apt-get install -y sudo curl vim jq mysql-server' returned a non-zero code: 100
make: *** [Makefile:240: docker_local] Error 100

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build

cc @askdba

We use docker/lite/install_dependencies.sh to install mysql57 server and client

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Copy link
Contributor

@askdba askdba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--------------
mysql  Ver 14.14 Distrib 5.7.31, for Linux (x86_64) using  EditLine wrapper

Connection id:		1
Current database:	commerce
Current user:		vt_app@localhost
SSL:			Not in use
Current pager:		stdout
Using outfile:		''
Using delimiter:	;
Server version:		5.7.9-Vitess MySQL Community Server (GPL)
Protocol version:	10
Connection:		127.0.0.1 via TCP/IP
Server characterset:	utf8
Db     characterset:	utf8
Client characterset:	utf8
Conn.  characterset:	utf8
TCP port:		15306
--------------```

…ysql-server

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

Waiting a few more days before merging since Holidays are slow for reviews.

…ysql-server

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@doeg
Copy link
Contributor

doeg commented Dec 27, 2020

Thank you so much for fixing this! 🎉

@shlomi-noach
Copy link
Contributor Author

Self reminder to merge this on Wednesday since everyone was out for so long.

@askdba
Copy link
Contributor

askdba commented Jan 4, 2021

Self reminder to merge this on Wednesday since everyone was out for so long.

If you merge it tomorrow it'll make it to v9.0.RC1

@shlomi-noach shlomi-noach merged commit a7c3dfa into vitessio:master Jan 4, 2021
@shlomi-noach shlomi-noach deleted the make-docker-fix-mysql-server branch January 4, 2021 13:56
@shlomi-noach
Copy link
Contributor Author

OK fine 😂

@askdba askdba added this to the v9.0 milestone Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants