Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #7255: VReplication DryRun: Report current dry run results for v2 commands #7345

Merged
merged 3 commits into from
Jan 22, 2021
Merged

Backport #7255: VReplication DryRun: Report current dry run results for v2 commands #7345

merged 3 commits into from
Jan 22, 2021

Conversation

rohit-nayak-ps
Copy link
Contributor

No description provided.

@rohit-nayak-ps
Report current dry run results for v2 commands
d12d85d 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Addressed review comments
41ced66 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Address review comment
3e7c0fe 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps requested review from sougou, deepthi and a team January 22, 2021 10:49
deepthi
deepthi approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi
Copy link
Member

deepthi commented Jan 22, 2021

@rohit-nayak-ps since this is a cherry-pick PR I have approved it, though it is still marked as Draft. Please merge when you are ready.

@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review January 22, 2021 21:50
@rohit-nayak-ps
Copy link
Contributor Author

rohit-nayak-ps commented Jan 22, 2021 •
edited by shlomi-noach

@rohit-nayak-ps since this is a cherry-pick PR I have approved it, though it is still marked as Draft. Please merge when you are ready.

Thanks, forgot to move it out of Draft.

@rohit-nayak-ps rohit-nayak-ps merged commit c8f5d98 into vitessio:release-9.0 Jan 22, 2021
@rohit-nayak-ps rohit-nayak-ps deleted the rn-backport-7255 branch January 22, 2021 21:51
@askdba askdba added this to the v9.0 milestone Jan 25, 2021
@rafael rafael mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@doeg doeg Awaiting requested review from doeg

Assignees
No one assigned
Labels
Component: VReplication
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rohit-nayak-ps @deepthi @askdba