Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtadmin-web] Set document.title from route components #7450

Merged
merged 1 commit into from Feb 5, 2021
Merged

[vtadmin-web] Set document.title from route components #7450

merged 1 commit into from Feb 5, 2021

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Feb 5, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

You'd think an effectively two-line change to update the document.title wouldn't require 30 lines of commentary and caveats... and yet.

Related Issue(s)

N/A

Checklist

  • Should this PR be backported?
  • Tests were added or are not required N/A
  • Documentation was added or is not required

Deployment Notes

N/A

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@doeg doeg requested a review from ajm188 as a code owner February 5, 2021 01:56
@doeg doeg assigned rohit-nayak-ps and unassigned ajm188 and rohit-nayak-ps Feb 5, 2021
@doeg
[vtadmin-web] Set document.title from route components
819e0dc 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg force-pushed the sarabee-vtadmin-document-title branch from 616f26c to 819e0dc Compare February 5, 2021 02:02
ajm188
ajm188 approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and yet .......... lg2m!

@rohit-nayak-ps rohit-nayak-ps merged commit caf7384 into vitessio:master Feb 5, 2021
@askdba askdba added the Component: VTAdmin VTadmin interface label Feb 8, 2021
@askdba askdba added this to the v10.0 milestone Feb 8, 2021
@doeg doeg added this to In progress in VTAdmin via automation Mar 16, 2021
@doeg doeg moved this from In progress to Done in VTAdmin Mar 16, 2021
@doeg doeg deleted the sarabee-vtadmin-document-title branch November 1, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 ajm188 approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps

Assignees
No one assigned
Labels
Component: VTAdmin VTadmin interface
Projects
VTAdmin
Done
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@doeg @ajm188 @askdba @rohit-nayak-ps