Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: remove mutexes #7468

Merged
merged 1 commit into from Feb 9, 2021
Merged

Commits on Feb 8, 2021

  1. plan: remove mutexes

    The mutexes that were guarding the 'stats' section of plans in vtgate
    and vttablet were not being properly obeyed. A lot of the code was
    accessing the stats without acquiring the mutex first, mostly because
    there is no global consistency requirement between all the fields of the
    stats. Because of this, remove the Mutexes from both plans and switch to
    using Atomic operations to handle the stats fields. This reduces the
    sizes of the plans on cache and improves the accuracy of our memory
    usage metrics, since we do not have accurate size calculations for mutex
    objects, as they're foreign to the project.
    
    Signed-off-by: Vicent Marti <vmg@strn.cat>
    vmg committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    2ec7e14 View commit details
    Browse the repository at this point in the history