-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[reparentutil / ERS] confirm at least one replica succeeded to SetMaster
, or fail
#7486
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
53cdbfe
[ERS] confirm at least one replica succeeded to `SetMaster`, or fail
ajm188 1ee9045
Fix data setup for `reparentShardLocked` cases, handle `Before` == ni…
ajm188 6d70d98
Remove the channel-based signalling in favor of just `AllErrorRecorde…
ajm188 b9fe9a4
PR feedback: attempt to clarify a comment
ajm188 cdffd63
Update `ReplicaWasRunning` to propagate error checking, update tests …
ajm188 8f2e1fc
Refactor promotePrimary to separate defensive cases from normal error…
ajm188 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. IIUC, the calls to
SetMaster
are bounded byWaitReplicasTimeout
which guarantees thatallReplicasDoneCancel
is eventually called.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Precisely!