Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table parsing on VSchema generation #7511

Merged
merged 2 commits into from Feb 18, 2021

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Feb 18, 2021

Description

On Vschema Generation we parse the table and it did not handled reserved and non-reserved keywords.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving

…reserved keywords

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal changed the title fix table parsing for VSchema generation to include reserved and non reserved keywords Fix table parsing on VSchema generation Feb 18, 2021
@harshit-gangal harshit-gangal marked this pull request as ready for review February 18, 2021 07:26
@systay systay merged commit 1158ed4 into vitessio:release-9.0 Feb 18, 2021
@systay systay deleted the fix-vschemagen branch February 18, 2021 13:53
@askdba askdba added this to the v10.0 milestone Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants