Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: keyword lookups in the tokenizer #7606

Merged
merged 3 commits into from
Mar 5, 2021
Merged

perf: keyword lookups in the tokenizer #7606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54c7143
sqlparser: improve benchmarks
vmg Mar 3, 2021
92b21f9
sqlparser: use a perfect hash table for keywords
vmg Mar 3, 2021
e25d0fb
sqlparser: use testify for tests
vmg Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/vt/sqlparser/ast_funcs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ func containEscapableChars(s string, at AtCount) bool {
}

func isKeyword(s string) bool {
_, isKeyword := keywords[s]
_, isKeyword := keywordLookupTable.LookupString(s)
return isKeyword
}

Expand Down