Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: reset stat at the beginning of test #7644

Merged
merged 1 commit into from Mar 9, 2021
Merged

tests: reset stat at the beginning of test #7644

merged 1 commit into from Mar 9, 2021

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Mar 8, 2021

Fixes flaky test failure:

--- FAIL: TestListenerShutdown (0.00s)
Error:     server_test.go:250: listening on address '::1' port 40883
Error:     server_test.go:1330: Expected connRefuse delta=1, got 1
FAIL

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@deepthi
tests: reset stat at the beginning of test
6442bd4 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi merged commit e84e366 into vitessio:master Mar 9, 2021
@deepthi deepthi deleted the ds-fix-flaky-stat branch March 9, 2021 00:04
@askdba askdba added this to the v10.0 milestone Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

@systay systay Awaiting requested review from systay

Assignees
No one assigned
Labels
Component: Build/CI
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deepthi @sougou @askdba