Use Dba user when Vexec is runAsAdmin #7731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makinje16
requested review from
deepthi,
rohit-nayak-ps and
shlomi-noach
as code owners
rafael
reviewed
Mar 24, 2021
There was a problem hiding this comment.
Added coupled comments.
One extra thing is that we should add a test to assert this is working as expected. An idea to test this is to add a test in go/vt/vttablet/tabletmanager/vreplication/engine_test.go where before running ExecWithDBa you set up bad credentials for the dba user and expect it to fail.
We can also check with @deepthi if she has other recommendations on how to test this.
makinje16
force-pushed
the
vitess-7585-dba-vrep
branch
from
53513c4
to
7be425f
Compare
deepthi
approved these changes
Apr 5, 2021
Signed-off-by: Malcolm Akinje <makinje@slack-corp.com>
makinje16
force-pushed
the
vitess-7585-dba-vrep
branch
from
33721f3
to
25e5c8b
Compare
rafael
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
All comments have been addressed. This looks good @makinje16 !
rafael
added a commit
to tinyspeck/vitess
that referenced
this pull request
Apr 7, 2021
Use Dba user when Vexec is runAsAdmin
systay
added
Component: VReplication
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Malcolm Akinje makinje@slack-corp.com
Description
This PR helps solve issue #7585 by allowing
VEngine.Execto take a runAsAdmin parameter which will decide whether to use theDbaorFiltereddb user.Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: