Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update moby/term to fix darwin build issue #7787

Merged
merged 2 commits into from
Apr 6, 2021
Merged

update moby/term to fix darwin build issue #7787

merged 2 commits into from
Apr 6, 2021

Conversation

gedgar
Copy link
Contributor

@gedgar gedgar commented Apr 6, 2021 •
edited by systay

Description

Update moby/term to fix darwin build issue, as described in #7788

Related Issue(s)

Checklist

  • Should this PR be backported? Yes, should go into v10

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@gedgar
update moby/term to fix darwin build issue on docker
64ba36a 
Signed-off-by: Gary Edgar <gary@planetscale.com>
@gedgar gedgar changed the title update moby/term to fix darwin build issue on docker update moby/term to fix darwin build issue Apr 6, 2021
@gedgar gedgar mentioned this pull request Apr 6, 2021
Closed
@deepthi deepthi requested a review from systay April 6, 2021 04:31
@deepthi deepthi mentioned this pull request Apr 6, 2021
Merged
8 tasks
@shlomi-noach
go mod tidy
3b96ca3 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor

issued go mod tidy to fix the test

@systay systay marked this pull request as ready for review April 6, 2021 14:48
@systay systay merged commit 7efa6aa into vitessio:master Apr 6, 2021
@systay systay deleted the planetscale/gedgar-update-moby-term branch April 6, 2021 14:52
@askdba askdba added this to the v11.0 milestone Apr 13, 2021
@systay systay mentioned this pull request Apr 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

Assignees
No one assigned
Labels
Component: Build/CI Type: Bug
Projects
None yet
Milestone
v11.0
Development

Successfully merging this pull request may close these issues.

Issue building Vitess binaries on Mac OSX
4 participants
@gedgar @shlomi-noach @systay @askdba