Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for showing global vgtid executed #7797

Merged
merged 13 commits into from
Apr 13, 2021

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Apr 6, 2021

Signed-off-by: Harshit Gangal harshit@planetscale.com

Description

This PR adds a new query to show vgtid i.e. group all the current gtid_executed.

mysql> show global vgtid_executed;
+----------+------------------------------------------------------------------------------------------------+
| keyspace | global vgtid_executed                                                                          |
+----------+------------------------------------------------------------------------------------------------+
| commerce | shard_gtids:<keyspace:"commerce" shard:"0" gtid:"bfb145e3-98ec-11eb-b9a7-98af65a6dc4a:1-23" >  |
+----------+------------------------------------------------------------------------------------------------+
1 row in set (0.01 sec)

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…ve and show in plan description only if set

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal marked this pull request as ready for review April 9, 2021 04:30
Signed-off-by: Andres Taylor <andres@planetscale.com>
"Query": s.Query,
"Table": s.GetTableName(),
}
if s.IsDML {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. much easier on the eyes

@deepthi
Copy link
Member

deepthi commented Apr 12, 2021

@harshit-gangal based on our discussion this morning, isn't the syntax going to change?

@harshit-gangal
Copy link
Member Author

@harshit-gangal based on our discussion this morning, isn't the syntax going to change?

We will be keeping this and also have one for shard GTIDs

@harshit-gangal harshit-gangal merged commit 3481a8f into vitessio:master Apr 13, 2021
@harshit-gangal harshit-gangal deleted the show-vgtid branch April 13, 2021 07:53
@askdba askdba added this to the v11.0 milestone Apr 13, 2021
@deepthi
Copy link
Member

deepthi commented Apr 13, 2021

@harshit-gangal based on our discussion this morning, isn't the syntax going to change?

We will be keeping this and also have one for shard GTIDs

Then this doesn't really fix #7400, correct? Should that issue be re-opened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: VTGate support for retrieving GTIDs from shards
4 participants