Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add cross-build target for cross-compiling client binaries #7806

Merged
merged 3 commits into from
Apr 12, 2021

Conversation

gedgar
Copy link
Contributor

@gedgar gedgar commented Apr 8, 2021

Signed-off-by: Gary Edgar gary@planetscale.com

Description

Adds a cross-build target which allows you to cross-compile Vitess binaries.
This makes it easier build a slim client tarball (namely, vtexplain + vtctl{,d}client) for OSX from Linux, which we can start including in PlanetScale's biweekly Vitess release.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

…ctlclient) binaries

Signed-off-by: Gary Edgar <gary@planetscale.com>
@gedgar gedgar marked this pull request as ready for review April 8, 2021 02:41
@deepthi deepthi requested a review from vmg April 8, 2021 15:38
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Gary Edgar <gary@planetscale.com>
Signed-off-by: Gary Edgar <gary@planetscale.com>
@deepthi deepthi changed the title Makefile: add xbuild target for cross-compiling client binaries Makefile: add cross-build target for cross-compiling client binaries Apr 12, 2021
@deepthi deepthi merged commit 85f598d into vitessio:master Apr 12, 2021
@deepthi deepthi deleted the planetscale/gedgar-xbuild branch April 12, 2021 19:57
@askdba askdba added this to the v11.0 milestone Apr 13, 2021
@systay systay mentioned this pull request Apr 23, 2021
@systay systay added Component: Build/CI Type: Enhancement Logical improvement (somewhere between a bug and feature) and removed Severity 4 Type: CI/Build labels Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build/CI Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants