[vtadmin-api] Reintroduce include_non_serving_shards opt to GetSchema #7814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com
Description
This reintroduces the
include_non_serving_shards
option to vtadmin-api'sGetSchema
endpoint. Originally, @ajm188 implemented it as part of PR #7751. It was removed in 9d5a725#diff-2e928c52fc65f3997825899db022e6259e1d9bdf5f1202fa31b83a77636ce555L648 since, at the time, we couldn't think of any use cases... and, of course, we thought of one ten days later. :') So, I am but a humble copy + paste goblin, reintroducing Andrew's existing work.For a little more context, in the short-term, we plan to use this in vtadmin-web to calculate copy progress for vreplication streams in the
copying
phase. Long-term, we plan to implement this more 馃槑 robustly 馃槑 in vtadmin-api. This work is ticketed as #7813.I'm not going to spend time constructing a local Vitess example, but I did verify that this works
on my machineinternally. :)Related Issue(s)
Checklist
Deployment Notes
N/A
Impacted Areas in Vitess
Components that this PR will affect: