Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-api] Reintroduce include_non_serving_shards opt to GetSchema #7814

Merged

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Apr 9, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

This reintroduces the include_non_serving_shards option to vtadmin-api's GetSchema endpoint. Originally, @ajm188 implemented it as part of PR #7751. It was removed in 9d5a725#diff-2e928c52fc65f3997825899db022e6259e1d9bdf5f1202fa31b83a77636ce555L648 since, at the time, we couldn't think of any use cases... and, of course, we thought of one ten days later. :') So, I am but a humble copy + paste goblin, reintroducing Andrew's existing work.

For a little more context, in the short-term, we plan to use this in vtadmin-web to calculate copy progress for vreplication streams in the copying phase. Long-term, we plan to implement this more 馃槑 robustly 馃槑 in vtadmin-api. This work is ticketed as #7813.

I'm not going to spend time constructing a local Vitess example, but I did verify that this works on my machine internally. :)

Related Issue(s)

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg added this to In progress in VTAdmin via automation Apr 9, 2021
@doeg
Copy link
Contributor Author

doeg commented Apr 9, 2021

Yikes, that's a lot of test failures... looking.

@doeg
Copy link
Contributor Author

doeg commented Apr 9, 2021

Ok turns out all those test failures were flakes 馃槑 I re-ran 'em and everything is passing now, so this is ready for review when you get a chance! 馃檱 鉂わ笍

Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!! lg2m

@ajm188 ajm188 merged commit 0672300 into vitessio:master Apr 9, 2021
VTAdmin automation moved this from In progress to Done Apr 9, 2021
@askdba askdba added the Component: VTAdmin VTadmin interface label Apr 13, 2021
@askdba askdba added this to the v11.0 milestone Apr 13, 2021
@doeg doeg deleted the sarabee-include-include-non-serving-shards branch November 1, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants