[vtadmin-web] Add DataCell component #7817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
ajm188
approved these changes
Apr 10, 2021
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
|
I had to sneak in a small change. 馃槉 |
ajm188
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com
Description
A couple of straightforward styling changes that I keep re-implementing in my bigger branches. 馃槑 Figured I should just pull them out into their own thing:
Adds a DataCell component for consistent styling. (A separate component will make more sense when we do rowspan grouping... I admit right now it's kinda overkill, haha. But! Still convenient.)
Renders cluster as secondary text where it "makes sense", which is (for now) when the cardinality of clusters is << the cardinality of whatever the table is rendering. Every cluster has many tablets, for example, so a separate "cluster" column is quite redundant when every row on a page is for the same cluster. Some tables, though, only have one or two columns right now, and in those cases I left the "cluster" column as a space filler. :)
Before:
After:
Related Issue(s)
N/A
Checklist
Deployment Notes
N/A
Impacted Areas in Vitess
Components that this PR will affect: