Routing of Information Schema Queries #7841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
harshit-gangal
approved these changes
Apr 21, 2021
systay
pushed a commit
to planetscale/vitess
that referenced
this pull request
May 11, 2021
Backport of vitessio#7841 * made sysTableTableSchema a slice and fixed merging for SelectDBA queries * updated tests * added tests * changed error message Signed-off-by: GuptaManan100 <manan@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
rafael
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
May 11, 2021
Backport of vitessio#7841 * made sysTableTableSchema a slice and fixed merging for SelectDBA queries * updated tests * added tests * changed error message Signed-off-by: GuptaManan100 <manan@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request fixes the routing regarding Information Schema Queries. More information schema queries can now be merged correctly.
SysTableTableSchemaandSysTableTableNameare now made lists and the error is thrown from the executor instead of the planner.Related Issue(s)
Checklist
Impacted Areas in Vitess
Components that this PR will affect: