[vtadmin-web] Add useSyncedURLParam hook to persist filter parameter in the URL #7857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doeg
force-pushed
the
sarabee-vtadmin-web-useSyncedURLParam
branch
4 times, most recently
from
72e0116
to
e7cb303
Compare
ajm188
approved these changes
Apr 14, 2021
…iews Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
doeg
force-pushed
the
sarabee-vtadmin-web-useSyncedURLParam
branch
from
e7cb303
to
0e74478
Compare
systay
added
Component: VTAdmin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com
Description
This adds
useSyncedURLParam, a hook for synchronizing values (particularly user input) with the URL. The principle here is that every view of VTAdmin should be encoded in the URL, so it's easy to share what you're seeing with someone else. 😎url-query-syncing.mov
This is a fairly straightforward implementation to get something out the door. I already have some improvements in mind, based on our internal prototype, so I added a fair amount of commentary + unit tests so it's easy to update down the road.
Related Issue(s)
N/A
Checklist
Deployment Notes
N/A
Impacted Areas in Vitess
Components that this PR will affect: