Wrangler tests: Return a fake tablet in the wrangler test dialer to avoid tablet picker errors spamming the test logs

[rohit-nayak-ps]

Signed-off-by: Rohit Nayak rohit@planetscale.com

Description

The wrangler test framework was incorrectly creating a lot of unnecessary logs like shown below. The fake tablets it creates don't always contain a valid QueryService implementation since the tests don't need it. The tablet picker started logging these as warnings when it was reimplemented resulting in inaccurate logs.

This PR returns a fake queryserivice in such cases so that the picker doesn't log them. Some residual logs are also removed.

In WranglerTest dialer
In WranglerTest dialer
In WranglerTest dialer
In WranglerTest dialer
W0413 14:28:22.422144   31135 tablet_picker.go:133] unable to connect to tablet for alias cell:"cell1" uid:10 
W0413 14:28:22.422121   31135 tablet_picker.go:133] unable to connect to tablet for alias cell:"cell1" uid:10 
In WranglerTest dialer
W0413 14:28:22.422185   31135 tablet_picker.go:133] unable to connect to tablet for alias cell:"cell1" uid:10 
W0413 14:28:22.422253   31135 tablet_picker.go:133] unable to connect to tablet for alias cell:"cell1" uid:10 

Related Issue(s)

Checklist

• Should this PR be backported?
• Tests were added or are not required
• Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

• Query Serving
• VReplication
• Cluster Management
• Build/CI
• VTAdmin

[deepthi]

LGTM