Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-web] Display more data on /gates view and add filtering #7876

Merged
merged 2 commits into from
Apr 18, 2021

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Apr 15, 2021

Description

A small PR to restructure the /gates view + add a filter input. (If... you hadn't noticed, I'm still favoring repetition over (bad) abstraction for these list views on purpose, since they'll diverge in significant ways when we add the dropdown filters and ... I've already made the mistake of poor abstraction in our internal prototype.) 馃槑

Before:

Screen Shot 2021-04-15 at 3 27 36 PM

After:

Screen Shot 2021-04-15 at 3 26 05 PM

Screen Shot 2021-04-15 at 3 26 09 PM

Related Issue(s)

N/A

Checklist

  • Should this PR be backported? Nope
  • Tests were added or are not required N/A
  • Documentation was added or is not required

Deployment Notes

N/A

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajm188 ajm188 merged commit 9008a8e into vitessio:master Apr 18, 2021
@systay systay added Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Apr 28, 2021
@doeg doeg deleted the sarabee-vtadmin-web-gates-updates branch November 1, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants