[vtadmin] Promote ErrNoSchema to a TypedError which returns http 404 #7885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
commented
Apr 18, 2021
| } | ||
|
|
||
| func (e *NoSuchSchema) Code() string { return "no such schema" } | ||
| func (e *NoSuchSchema) HTTPStatus() int { return http.StatusNotFound } |
There was a problem hiding this comment.
Open TODO for anyone to swap the rest of our magic numbers in this file to reference the constants in net/http
There was a problem hiding this comment.
Do you mean in this PR, or a separate one?
There was a problem hiding this comment.
Separate one! It's not really related to this change, but something we should do. https://github.com/vitessio/vitess/projects/12#card-59345039
ajm188
changed the title
systay
added
Component: VTAdmin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Mason amason@slack-corp.com
Description
Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: