ci: fix all racy tests #7904
Merged
ci: fix all racy tests #7904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vicent Marti <vmg@strn.cat>
Signed-off-by: Vicent Marti <vmg@strn.cat>
vmg
requested review from
ajm188,
deepthi,
doeg,
rohit-nayak-ps and
shlomi-noach
as code owners
Signed-off-by: Vicent Marti <vmg@strn.cat>
shlomi-noach
approved these changes
Apr 20, 2021
systay
added
Component: Query Serving
Type: Testing
Component: Build/CI
and removed
Component: Query Serving
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes all the racy tests in our unit test suite that I've managed to reproduce locally. @shlomi-noach: these are all legit and should get the build closer to consistently green, but if you can think of any flaky race that I've missed, please let me know.
Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: