Check tablet alias before removing after error stream #7915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crowu <y.wu4515@gmail.com>
deepthi
reviewed
Apr 21, 2021
go/vt/discovery/healthcheck.go
Outdated
| @@ -448,8 +453,7 @@ func (hc *HealthCheckImpl) updateHealth(th *TabletHealth, prevTarget *query.Targ | |||
| } | |||
| } | |||
| case isPrimary && !isPrimaryUp: | |||
| // No healthy master tablet | |||
| hc.healthy[targetKey] = []*TabletHealth{} | |||
| hc.deleteHealthDateLocked(targetKey, tabletAlias) | |||
There was a problem hiding this comment.
I don't believe this is correct. We want to delete it from healthy but not from healthData.
There was a problem hiding this comment.
Updated to keep it same as the original logic.
Signed-off-by: crowu <y.wu4515@gmail.com>
|
This should also go into 10.0 (release-10.0 branch) |
5antelope
commented
Apr 21, 2021
go/vt/discovery/healthcheck.go
Outdated
| // No healthy master tablet | ||
| hc.healthy[targetKey] = []*TabletHealth{} | ||
| if healthy, ok := hc.healthy[targetKey]; ok && len(healthy) > 0 { | ||
| var newHealthy []*TabletHealth |
There was a problem hiding this comment.
@deepthi i don't know if this is the proper way to do the deletion in this case, please let me know if you have better suggestions
5antelope
force-pushed
the
ywu/health_check
branch
from
54b3b53
to
c477844
Compare
8 tasks
systay
added
Component: Cluster management
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: crowu y.wu4515@gmail.com
Description
When VTGate gets an error from the primary tablet connection, it should not just nuke out all the healthy tablets. Because an external reparent process might have already changed the primary tablet.
Instead we should only try to remove the tablet with stream error from the map
Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: