Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky race condition in vtexplain #7930

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Fix flaky race condition in vtexplain #7930

merged 2 commits into from
Apr 22, 2021

Conversation

shlomi-noach
Copy link
Contributor

Description

Fixing a long-time recurring race condition in Unit_race in vtexplain code.

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@shlomi-noach
fix flaky race condition: vtexplain
527a17d 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
merged master, resolved conflict
13a68c2 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach changed the title Fix race condition flaky vtexplain Fix flaky race condition in vtexplain Apr 22, 2021
@shlomi-noach shlomi-noach merged commit 0069b5f into vitessio:master Apr 22, 2021
@shlomi-noach shlomi-noach deleted the fix-race-condition-flaky-vtexplain branch April 22, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 ajm188 approved these changes

Assignees
No one assigned
Labels
Component: Build/CI Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shlomi-noach @ajm188 @systay