Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan StreamExecute Queries #7941

Merged
merged 14 commits into from
Apr 29, 2021
Merged

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Apr 23, 2021

Description

This is about refactoring the StreamExecute method in executor where the queries received with go through planning phase and then will be executed based on the plan outcome.

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal changed the title Plan treamExecute Plan StreamExecute Queries Apr 23, 2021
@harshit-gangal harshit-gangal marked this pull request as draft April 23, 2021 06:04
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal requested review from rohit-nayak-ps and removed request for GuptaManan100 April 27, 2021 10:30
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal marked this pull request as ready for review April 27, 2021 10:45
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Copy link
Collaborator

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only found a couple of minor things

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal merged commit 9ee1e9c into vitessio:master Apr 29, 2021
@harshit-gangal harshit-gangal deleted the planner-olap branch April 29, 2021 12:45
@harshit-gangal harshit-gangal restored the planner-olap branch May 7, 2021 07:06
@indera-shsp
Copy link
Contributor

Is there an RFC doc for this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants