Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing flaky endtoend/tablegc tests #7947

Merged
merged 3 commits into from
Apr 25, 2021

Conversation

shlomi-noach
Copy link
Contributor

Description

Fixes #7878

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

Example for failed test: https://github.com/vitessio/vitess/runs/2421562090?check_suite_focus=true (shard named 27 now renamed in this PR to tabletmanager_tablegc):

== RUN   TestPopulateTable
--- PASS: TestPopulateTable (0.02s)
=== RUN   TestHold
--- PASS: TestHold (15.03s)
=== RUN   TestEvac
--- PASS: TestEvac (20.03s)
=== RUN   TestDrop
--- PASS: TestDrop (20.03s)
=== RUN   TestPurge
    tablegc_test.go:331: 
        	Error Trace:	tablegc_test.go:331
        	Error:      	Should be false
        	Test:       	TestPurge
    tablegc_test.go:337: 
        	Error Trace:	tablegc_test.go:337
        	Error:      	Should be true
        	Test:       	TestPurge
    tablegc_test.go:123: 
        	Error Trace:	tablegc_test.go:123
        	            				tablegc_test.go:338
        	Error:      	Should NOT be empty, but was 
        	Test:       	TestPurge
--- FAIL: TestPurge (65.03s)
FAIL
FAIL	vitess.io/vitess/go/test/endtoend/tabletmanager/tablegc	146.848s
FAIL

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach marked this pull request as ready for review April 25, 2021 12:05
@shlomi-noach
Copy link
Contributor Author

This should be good to go. Basically just incrmented some sleep time to let the mechnism do its expected work.

@harshit-gangal
Copy link
Member

I think this needs to be removed "Run endtoend tests on Cluster (27) Expected — Waiting for status to be reported"

@shlomi-noach
Copy link
Contributor Author

I think this needs to be removed "Run endtoend tests on Cluster (27) Expected — Waiting for status to be reported"

Indeed. Thank you!

@shlomi-noach
Copy link
Contributor Author

Removed Run endtoend tests on Cluster (27) from being Required. Merging and then adding tabletmanager_tablegc as Required.

@shlomi-noach shlomi-noach merged commit bbdc9a1 into vitessio:master Apr 25, 2021
@shlomi-noach shlomi-noach deleted the flaky-tablegc-test branch April 25, 2021 14:05
@shlomi-noach shlomi-noach mentioned this pull request May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TableGC Flaky Test
3 participants