Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtadmin-web] Add filtering and source/target shards to Workflows view #7948

Merged
merged 2 commits into from
Apr 25, 2021
Merged

[vtadmin-web] Add filtering and source/target shards to Workflows view #7948

merged 2 commits into from
Apr 25, 2021

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Apr 25, 2021

Description

A couple of minor changes to the Workflows view, namely:

  • Adds URL-persisted filtering
  • Renders the source/target shards for each workflow in the list

Before:

Screen Shot 2021-04-25 at 3 10 07 PM

After:

Screen Shot 2021-04-25 at 3 10 26 PM

Related Issue(s)

N/A

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required N/A
  • Documentation was added or is not required N/A

Deployment Notes

N/A

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@doeg
[vtadmin-web] Render shards on Workflows view
f8c9a96 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
[vtadmin-web] Add filtering to Workflows view
ed3a055 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg added this to In progress in VTAdmin via automation Apr 25, 2021
ajm188
ajm188 approved these changes Apr 25, 2021
View reviewed changes
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:chef-kiss:

@ajm188 ajm188 merged commit 7c1eb31 into vitessio:master Apr 25, 2021
VTAdmin automation moved this from In progress to Done Apr 25, 2021
@systay systay added Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Apr 28, 2021
@doeg doeg deleted the sarabee-vtadmin-web-workflows-nits branch November 1, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 ajm188 approved these changes

@rafael rafael Awaiting requested review from rafael

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps

Assignees
No one assigned
Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
VTAdmin
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doeg @ajm188 @systay