Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a gofmt warning #7959

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Fix a gofmt warning #7959

merged 1 commit into from
Apr 27, 2021

Conversation

Hellcatlk
Copy link
Contributor

Signed-off-by: Zou Yu zouy.fnst@cn.fujitsu.com

Description

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@Hellcatlk
Fix a gofmt warning
cdab304 
Signed-off-by: Zou Yu <zouy.fnst@cn.fujitsu.com>
shlomi-noach
shlomi-noach approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Interestingly, CI's gofmt doesn't report this as an issue, neither does my local gofmt. Curious which go version you're using?

@Hellcatlk
Copy link
Contributor Author

Looks good, thank you! Interestingly, CI's gofmt doesn't report this as an issue, neither does my local gofmt. Curious which go version you're using?

I added -s when I used gofmt(not go fmt).

@shlomi-noach shlomi-noach merged commit 2e1b1e9 into vitessio:master Apr 27, 2021
@systay systay added the Type: Enhancement Logical improvement (somewhere between a bug and feature) label Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach approved these changes

Assignees
No one assigned
Labels
Component: Build/CI Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Hellcatlk @shlomi-noach @systay @askdba