Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler|workflow] Extract vrStream type to workflow.VReplicationStream #7966

Merged

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Apr 27, 2021

Signed-off-by: Andrew Mason amason@slack-corp.com

Description

More incremental refactors! This one pulls out the private vrStream type to workflow.VReplicationStream and also defines a list type to provide the behaviors of tabletStreamValues, tabletStreamWorkflows, copyTabletStreams

Related Issue(s)

Checklist

  • Tests were added or are not required n/a
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 requested a review from deepthi as a code owner April 27, 2021 14:09
@ajm188 ajm188 changed the title Extract vrStream type to workflow.VReplicationStream [wrangler|workflow] Extract vrStream type to workflow.VReplicationStream Apr 27, 2021
@ajm188 ajm188 requested review from doeg and makinje16 April 27, 2021 14:14
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajm188 ajm188 merged commit f5ed5b9 into vitessio:master Apr 30, 2021
@ajm188 ajm188 deleted the am_extract_vrepstream_from_wrangler branch April 30, 2021 15:21
@ajm188 ajm188 added this to In progress in Vtctld Service via automation May 7, 2021
@ajm188 ajm188 moved this from In progress to Done in Vtctld Service May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants