docker/vttestserver/run.sh: Add $CHARSET environment variable #7970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should create a separate issue & PR for the default change (once we decide it is safe to do so). |
|
@deepthi SGTM :) |
Signed-off-by: Mike Cronce <mc@planetscale.com>
mcronce
force-pushed
the
vttestserver-default-charset
branch
from
7e2b11f
to
ff8c750
Compare
deepthi
approved these changes
Apr 27, 2021
systay
added
Component: Build/CI
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds an environment variable to pass through to vttestserver's
-charsetcommand-line flag, and defaults it toutf8mb4. This, among other things, enables a portion Prisma's integration test suite that validates certain Unicode support.Related Issue(s)
#7942
Checklist
Deployment Notes
This only changes the vttestserver containers. @harshit-gangal mentioned in #7942 making it the default in vttablet. This PR does not do that, so I don't disagree with leaving that issue open if we consider that a requirement.