Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change vreplication error metric name to start with a string to pass prometheus validations #7983

Merged
merged 1 commit into from
May 2, 2021
Merged

Change vreplication error metric name to start with a string to pass prometheus validations #7983

merged 1 commit into from
May 2, 2021

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Apr 28, 2021 •
edited

Signed-off-by: Rohit Nayak rohit@planetscale.com

Description

The vreplication error metric started with a number. Fixed by prefixing with the workflow name. Per prometheus docs the required naming convention is:

Label names may contain ASCII letters, numbers, as well as underscores. They must match the regex [a-zA-Z_][a-zA-Z0-9_]*. Label names beginning with __ are reserved for internal use.

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

@rohit-nayak-ps
Change vreplication error metric name to start with a string to pass …
09e74af 
…prometheus validations

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps requested review from a team, deepthi and ajm188 April 28, 2021 14:39
ajm188
ajm188 approved these changes May 2, 2021
View reviewed changes
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohit-nayak-ps rohit-nayak-ps merged commit 2544e5a into vitessio:master May 2, 2021
@rohit-nayak-ps rohit-nayak-ps deleted the rn-metrics-fix branch May 2, 2021 09:46
@rohit-nayak-ps rohit-nayak-ps mentioned this pull request May 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 ajm188 approved these changes

@deepthi deepthi Awaiting requested review from deepthi

Assignees
No one assigned
Labels
Component: VReplication Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rohit-nayak-ps @ajm188