Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-web] Add filtering + shard counts/status to Keyspaces view #7991

Merged

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Apr 28, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

The branch I'm working on to add the Keyspace details view is getting big, so I'm peeling off this PR-sized chonk to add standard URL filtering to the Keyspaces view.

Screen Shot 2021-04-28 at 5 38 13 PM

Screen Shot 2021-04-28 at 5 38 19 PM

Important note that filtering keyspaces by "has non-serving shards" will require some changes to how the filterNouns function works + is not included this change.

Related Issue(s)

N/A

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg added this to In progress in VTAdmin via automation Apr 28, 2021
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!

@ajm188 ajm188 merged commit 3fa9258 into vitessio:master Apr 29, 2021
VTAdmin automation moved this from In progress to Done Apr 29, 2021
@ajm188 ajm188 added Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature) labels May 21, 2021
@doeg doeg deleted the sarabee-vtadmin-web-keyspace-list-filtering branch November 1, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants