[vtadmin-web] Display shard state on Tablets view + extract tablet utilities #7999
Conversation
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
doeg
changed the title
| // The distinction between "is loading" and "is_master_serving is undefined" | ||
| // is useful, as it's common for the shard `shard.is_master_serving` to be | ||
| // excluded from API responses for non-serving shards (instead of being | ||
| // explicitly false.) |
There was a problem hiding this comment.
If it will make your life easier (or more pleasant!) I'm pretty sure we can change the JSON marshaling in the http adapter to not omit fields with zero values
There was a problem hiding this comment.
Oh that's good to know! Definitely not a blocker but seems useful for boolean + numeric values... perhaps one day I will change it, but in the meantime it doesn't really matter much. I made a card anyway: https://github.com/vitessio/vitess/projects/12#card-60142070 😎
There was a problem hiding this comment.
(That said, this made me think of a small change I want to make, so I'll do that real quick.)
There was a problem hiding this comment.
......... okay, so I did the change and it turns out I like it way less, so I think this is fine to merge as-is. Once this unit test passes anyway, haha.
ajm188
added
the
Type: Enhancement
Description
A few more small changes that will come in handy for the Keyspace + Workflow views:
utils/tablets.tsBefore:
After:
Related Issue(s)
Checklist
Deployment Notes
N/A