Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin] experimental tabletdebug #8003

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Apr 30, 2021

Description

This PR adds an experimental, http-only endpoint to vtadmin for making passthrough requests to a tablet's /debug/vars endpoint.

Example:

amason@some-host:~/vitess$ curl -s "${VTADMIN_URL}/api/experimental/tablet/${TABLET_HOSTNAME}/debug/vars | jq '.result.BuildGitBranch' 
HEAD

Related Issue(s)

Checklist

  • Tests were added or are not required – not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 requested review from rafael and doeg April 30, 2021 00:47
@ajm188 ajm188 added this to In progress in VTAdmin via automation Apr 30, 2021
Copy link
Contributor

@doeg doeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it 😈

We talked about this previously, but for posterity: is there anything I should keep in mind in querying this endpoint? Beyond the usual considerations like... y'know, "do not query this in an infinite loop".

A reasonable front-end implementation would poll this endpoint around once every second (per client) -- I believe we arrived at "this should not be a problem, and if it is a problem, we can tune it later", which works for me.

@ajm188
Copy link
Contributor Author

ajm188 commented Apr 30, 2021

🤔 I don't think so!! It's still experimental, so let's just keep going with "this should not be a problem, and if it is a problem, we can tune it later"

@ajm188 ajm188 merged commit 251d632 into vitessio:master Apr 30, 2021
VTAdmin automation moved this from In progress to Done Apr 30, 2021
@ajm188 ajm188 deleted the am_vtadmin_experimental_tabletdebug branch April 30, 2021 13:58
@askdba askdba added Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature) labels May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants