Ignore the error and log as warn if not able to validate the current system setting for check and ignore case #8004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…system settings value Signed-off-by: Harshit Gangal <harshit@planetscale.com>
systay
added
Component: Query Serving
Type: Enhancement
systay
approved these changes
May 3, 2021
systay
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…system settings value
Signed-off-by: Harshit Gangal harshit@planetscale.com
Description
Rather than returning the error, we will just log the error as the intention for executing the query it to validate the current setting and eventually ignore it anyways. There is no benefit of returning the error back to client.
Related Issue(s)
Fixes #7981
Checklist