[wrangler|workflow] extract *wrangler.streamMigrater to workflow.StreamMigrator
#8008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Delegate the external interface used by other components in `package wrangler` to use the `workflow.StreamMigrator` under the hood. Also, delete the templatize tests, but keep the other streamMigrater tests, because they invoke streamMigrater only indirectly. Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the bulk of the
stream_migrater.gocode inpackage wranglertopackage workflow, and then replaces the guts of the*wrangler.streamMigraterstruct with a pointer to the new type, and delegates all other function calls through to the new type (in order to minimize the number of callsites I needed to update, which I will come back to in the next PR).Note: the private
*wrangler.trafficSwitcherand*wrangler.streamMigratertypes depend on each other, so in order to not have to move both at once, and create a huge diff, I've temporarily defined aworkflow.ITrafficSwitcherinterface, which covers every function of*workflow.trafficSwitcherthat the StreamMigrator code depends on. This is extremely temporary, and, in the next next PR, I will migrate*trafficSwitcher, at which point we won't need that interface anymore.This also moves the private
streamTypeenum.Related Issue(s)
Checklist
Deployment Notes