Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-web] Display timestamps + stream counts on Workflows view #8009

Merged

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Apr 30, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

What the title says! This adds timestamps and stream counts to the Workflows view.

Before:

Screen Shot 2021-04-30 at 12 19 31 PM

Various afters:

Screen Shot 2021-04-30 at 11 51 39 AM

Screen Shot 2021-04-30 at 11 51 26 AM

Related Issue(s)

N/A

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg force-pushed the sarabee-vtadmin-web-workflow-utils branch from 5c5ffa5 to c0b9644 Compare April 30, 2021 17:18
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* updated stream in the workflow.
*/
export const getTimeUpdated = <W extends pb.IWorkflow>(workflow: W | null | undefined): number => {
// Note: long-term it may be better to get this from the `vreplication_log` data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@ajm188 ajm188 merged commit 350a92e into vitessio:master Apr 30, 2021
@askdba askdba added Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature) labels May 3, 2021
@ajm188 ajm188 added this to In progress in VTAdmin via automation May 21, 2021
@ajm188 ajm188 moved this from In progress to Done in VTAdmin May 21, 2021
@doeg doeg deleted the sarabee-vtadmin-web-workflow-utils branch November 1, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants