Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vreplicator docs #8014

Merged

Conversation

kirs
Copy link
Contributor

@kirs kirs commented May 1, 2021

In a few references in code and in the docs website I found that Only "in_keyrange" expressions are supported in the where clause - while that's not true and vreplication also supports plain equality comparisons like WHERE somecol='blah' (here's the code; it was shipped as part of #5949).

I'd like this to be clearly documented for others.

Signed-off-by: Kir Shatrov <shatrov@me.com>
@kirs kirs force-pushed the vreplication-select-where-docs branch from 2b4bbd9 to 5ed2da4 Compare May 1, 2021 21:03
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks, appreciate the documentation fix

@rohit-nayak-ps rohit-nayak-ps merged commit 092a935 into vitessio:master May 1, 2021
@kirs kirs deleted the vreplication-select-where-docs branch May 9, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants