-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Online DDL: progress & ETA for Vreplication migrations #8015
Online DDL: progress & ETA for Vreplication migrations #8015
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
This PR is generally good to go. I'm struggling if/whether to add Obviously it would be nice to test the behavior. But then, I'm not sure how to go about it. It would take a relatively long migration to be able to test this. We'd need a migration that is absolutely known to run for over |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Now also complements #8255 and updates When the migration completes, |
This is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
#7980 introduced VReplicaiton tracking for
rows_copied
. This PR both intensifies that tracking, and follows up in Online DDL: the online DDL executor periodically checksrows_copied
from_vt.vstream
, compares with estimatedtable_rows
, looks atstarted_timestamp
, and generates values forprogress
and foreta_seconds
.Online DDL does so every 1 minute, normally, which means the valuee
progress
andeta_seconds
are estimates only. Plus,vcopier
itself only updatesrows_copied
every30s
, so we could get almost a90s
stale value forprogress
andeta_seconds
. Which is acceptable to us at this tim.Related Issue(s)
rows_copied
#7980Checklist
Deployment Notes