livequeryz: livequeryz/terminate link should be relative #8025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link is displayed on the /livequeryz endpoint so there is no need for the link to be absolute. The fact that this link is absolute currently means that it does not work when it is behind a proxy like the PlanetScale configuration. Signed-off-by: Dylan Visher <dvisher@figma.com>
dyv
force-pushed
the
dvisher/livequeryz-links
branch
from
71e563f
to
5fe2e81
Compare
systay
approved these changes
May 4, 2021
systay
added
Component: Query Serving
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link is displayed on the /livequeryz endpoint so there is no need for the
link to be absolute. The fact that this link is absolute currently means that
it does not work when it is behind a proxy like the PlanetScale configuration.