Handle online DDL user creation if we do not have SUPER privs (e.g. AWS Aurora) #8038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS Aurora) Signed-off-by: Jacques Grove <aquarapid@gmail.com>
shlomi-noach
reviewed
May 5, 2021
That was to minimize the textual diff, but you're right, it can just appear in the 2nd one. Fixing. |
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
shlomi-noach
approved these changes
May 5, 2021
There was a problem hiding this comment.
For context, gh-ost user requirements: https://github.com/github/gh-ost/blob/master/doc/requirements-and-limitations.md#requirements, show s that we can do without SUPER in Vitess.
askdba
added
Component: Query Serving
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jacques Grove aquarapid@gmail.com