Add optional TLS feature to gRPC servers #8049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement TransportCredentials that allows a server to accept both TLS and plain-text connections at the same time on the same endpoint. To detect a connection type TransportCredentials inspects the first 6 bytes read from a socket and compares them against bytes in TLS prefix. A TLS prefix is different from plain-text HTTP2 prefix. Signed-off-by: Anton Tiurin <noxiouz@yandex.ru>
noxiouz
force-pushed
the
feature/optional_tls
branch
from
def9b77
to
96db82c
Compare
|
@noxiouz Thank you for the contribution. We can run CI once a reviewer has had a chance to look at the change. |
fixed :) |
noxiouz
commented
May 5, 2021
dkhenry
reviewed
May 5, 2021
dkhenry
approved these changes
May 5, 2021
use go/vt/tlstest to generate certificates log warning message when the option is on Signed-off-by: Anton Tiurin <noxiouz@yandex.ru>
|
Please, let me know if you need more details, tests, docs, etc from my side. I am happy to give any :) |
|
I think you should be good to go. I have just approved the CI to run for this PR |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement TransportCredentials that allows a gRPC server to accept both
TLS and plain-text connections at the same time on the same endpoint.
This feature is vital to migrating Vitess cluster in production from plain-text to TLS without downtime.
As Vitess components talk to each other via gRPC, currently, it's not possible to do a rolling update:
With the optional TLS feature this update is possible in 3 steps without downtime:
To detect a connection type TransportCredentials inspects the first 6 bytes read from a socket and compares them with TLS prefix. TLS prefix is different from plain-text HTTP2 prefix.
Originally implemented as a separate gRPC package: go-grpc-optionaltls-creds
Related Issue(s)
Checklist
Deployment Notes