Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tear down old stream_migrater shim, now that we're fully in package workflow #8073

Merged
merged 1 commit into from
May 8, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented May 7, 2021

Signed-off-by: Andrew Mason amason@slack-corp.com

Description

Title says it all. This is just a cleanup pass after the last bigger refactoring PR.

Related Issue(s)

Checklist

  • Tests were added or are not required - n/a
  • Documentation was added or is not required - n/a

Deployment Notes

…workflow`

Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 requested a review from deepthi as a code owner May 7, 2021 14:49
@ajm188 ajm188 added this to In progress in Vtctld Service via automation May 7, 2021
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajm188 ajm188 merged commit 24a665b into vitessio:master May 8, 2021
Vtctld Service automation moved this from In progress to Done May 8, 2021
@ajm188 ajm188 deleted the am_teardown_old_stream_migrater branch May 8, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants