Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-web] Add Tooltip + HelpTooltip components #8076

Merged
merged 1 commit into from
May 7, 2021

Conversation

doeg
Copy link
Contributor

@doeg doeg commented May 7, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

Finally! Hopefully the code is well-documented enough to be self-explanatory.

I wish I could say the same for the help-text I added, but I am by no means a copywriter of any skill so suggestions are (always) welcome.

Here's some screenshots:

Screen Shot 2021-05-07 at 2 50 35 PM

Screen Shot 2021-05-07 at 2 50 40 PM

Screen Shot 2021-05-07 at 2 50 44 PM

Screen Shot 2021-05-07 at 2 50 51 PM

Related Issue(s)

N/A

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg force-pushed the sarabee-vtadmin-web-tooltips branch from 04fe8f0 to 78e589d Compare May 7, 2021 18:58
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajm188 ajm188 merged commit cc9b903 into vitessio:master May 7, 2021
@ajm188 ajm188 added this to In progress in VTAdmin via automation May 21, 2021
@ajm188 ajm188 moved this from In progress to Done in VTAdmin May 21, 2021
@doeg doeg deleted the sarabee-vtadmin-web-tooltips branch November 1, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants