Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-web] The hastiest-ever VTExplain UI #8092

Merged
merged 1 commit into from
May 11, 2021

Conversation

doeg
Copy link
Contributor

@doeg doeg commented May 10, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

This adds a hasty VTExplain UI that does the 馃弳 Absolute Bare Minimum 馃弳 but it unblocks some internal work.

Screen Shot 2021-05-10 at 4 00 32 PM

Screen Shot 2021-05-10 at 4 00 35 PM

Related Issue(s)

I'll file a bunch of cards under https://github.com/vitessio/vitess/projects/12 for known enhancements (since we've accumulated a bunch on our internal prototype that are relevant here).

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg added this to In progress in VTAdmin via automation May 10, 2021
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

const { data, error, refetch } = useVTExplain(
{ cluster: clusterID, keyspace: keyspaceName, sql },
{
// Never cache, never refetch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never give up, never surrender

@ajm188 ajm188 merged commit 705202f into vitessio:master May 11, 2021
VTAdmin automation moved this from In progress to Done May 11, 2021
@ajm188 ajm188 deleted the sarabee-vtadmin-vtexplain branch May 11, 2021 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants